Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests.texlive.fixedHashes: init #248746

Merged
merged 1 commit into from
Aug 26, 2023
Merged

tests.texlive.fixedHashes: init #248746

merged 1 commit into from
Aug 26, 2023

Conversation

xworld21
Copy link
Contributor

Description of changes

The assertion that all TeX Live packages have a fixed hash is time consuming and should only be checked when running tests. This should improve the evaluation speed of texlive by some small margin.

I apologise for the tiny conflict with another open texlive PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@xworld21
tests.texlive.fixedHashes: init
decff78 
The assertion that all TeX Live packages have a fixed hash is time
consuming and should only be checked when running tests.
@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Aug 12, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 12, 2023
@veprbl
Copy link
Member

veprbl commented Aug 12, 2023

@GrahamcOfBorg build tests.texlive

@veprbl
Copy link
Member

veprbl commented Aug 13, 2023 

error: builder for '/nix/store/hpwypzd9jm8ls3ary9kmdngwyl02ysy0-texlive-test-license.drv' failed with exit code 1;
       last 10 log lines:
       >
       > license info for scheme-infraonly is incorrect! Note that order is enforced.
       > saved: [ gpl2 lgpl21 ]
       > correct: [ lgpl21 ]
       >
       >
       > license info for scheme-minimal is incorrect! Note that order is enforced.
       > saved: [ free gpl1Only gpl2 gpl2Plus knuth lgpl21 lppl1 lppl13c mit ofl publicDomain ]
       > correct: [ free gpl1Only gpl2Plus knuth lgpl21 lppl1 lppl13c mit ofl publicDomain ]
       >

@xworld21
Copy link
Contributor Author

license info for scheme-infraonly is incorrect! Note that order is enforced.
> saved: [ gpl2 lgpl21 ]
> correct: [ lgpl21 ]

This was spotted by @apfelkuchen6 and fixed in #247798 – where I was patching texlive.infra, so I added the gpl2 license while I was there.

@xworld21
Copy link
Contributor Author

@GrahamcOfBorg build tests.texlive.licenses tests.texlive.fixedHashes

@veprbl
Copy link
Member

veprbl commented Aug 20, 2023

@GrahamcOfBorg build tests.texlive

@apfelkuchen6 apfelkuchen6 mentioned this pull request Aug 21, 2023
Draft
12 tasks
@xworld21
Copy link
Contributor Author

Further motivation, for the record: the test must be moved also because the fixed hashes should be enforced on texlive as packaged in Nixpkgs. Overriding texlive outside of Nixpkgs should not require additional fixed hashes which is a side effect of the current assert.

@xworld21 xworld21 added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Aug 22, 2023
@veprbl veprbl merged commit 4e49e49 into NixOS:master Aug 26, 2023
@xworld21 xworld21 deleted the texlive-assert-fixed-hashes-in-test branch August 26, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@apfelkuchen6 apfelkuchen6 apfelkuchen6 approved these changes

Assignees
No one assigned
Labels
6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xworld21 @veprbl @apfelkuchen6